fix #58 add slip encoding and decoding - #62
Open
tm1000 wants to merge 2 commits into
Open
Conversation
add SLIP protocol support for TCP OSC 1.1 encoding/decoding
Author
|
@klingtnet there's a lot of Clippy errors which I didn't resolve because they were outside the scope of what I changed let me know if you want me to run clippy --fix and I can apply it here. Looks like you added clippy two months ago. The only thing left to fully configure for 1.1 support is #31 however I do not have any present need for that myself so i didnt implement it plus im not sure if it's the job of this library to deal with that at this level |
…ding and decoding logic for better clarity and maintainability ✅ (tests): add comprehensive tests for SLIP encoding and decoding to ensure correctness and handle edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58 add SLIP protocol support for TCP OSC 1.1 encoding/decoding