docs: add ADS mode deployment and usage guide#1620
docs: add ADS mode deployment and usage guide#1620Aaravanand00 wants to merge 5 commits intokmesh-net:mainfrom
Conversation
|
@Aaravanand00: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Kmesh's documentation by introducing a comprehensive guide for its ADS (Kernel-Native) mode. The new guide aims to clarify the deployment process and demonstrate the powerful traffic management capabilities offered by Kmesh leveraging eBPF for in-kernel L4 and L7 control, providing users with practical examples for various use cases. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. New docs now unfold, eBPF guides traffic with grace, Kernel's power shown. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for deploying and using Kmesh in ADS mode, including both English and Chinese versions. The documentation is well-structured, but the usage examples provided for Istio resources are incomplete. Specifically, the VirtualService examples rely on subsets that are not defined in any DestinationRule within the guide, which will prevent them from working correctly. I have added comments with suggestions to include the necessary DestinationRule configurations to make the examples functional and complete.
There was a problem hiding this comment.
Pull request overview
Adds new documentation to help users deploy and use Kmesh in ADS (Kernel-Native) mode, and surfaces the new guide from the project READMEs.
Changes:
- Add English ADS mode deployment/usage guide with verification and traffic-management examples.
- Add Chinese (zh) ADS mode deployment/usage guide mirroring the English version.
- Update README entry points to link to the new ADS mode guide(s) and existing demos.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/en/ads_mode_deployment_and_usage.md | New English guide for ADS (Kernel-Native) deployment, verification, and routing/LB/canary examples. |
| docs/cn/zh/ads_mode_deployment_and_usage.md | New Chinese guide mirroring the English ADS mode guide. |
| README.md | Updates “Quick Start” links to include the new ADS mode guide and correct doc paths. |
| README-zh.md | Adds links to the new Chinese ADS guide and other docs (but leaves an older broken demo link elsewhere in the file). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Aaravanand00 hey, please sign of DCO when you create any new pr or pushing any code. and try to avoid Chinese doc contribution if you are not familiar with Chinese language. it is not easy language like english. |
Aaravanand00
force-pushed
the
docs-ads-mode-guide
branch
from
ad955f8 to
c16913e
Compare
Aaravanand00
force-pushed
the
docs-ads-mode-guide
branch
from
bd33172 to
1155b8e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Added detailed requirements and design overview for Kmesh, including use cases, deployment views, and feature lists. Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
Aaravanand00
force-pushed
the
docs-ads-mode-guide
branch
from
27dbd9e to
fbfa044
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR adds a guide for deploying and using Kmesh in ADS (kernel-native) mode.
It includes setup steps, verification, and examples for routing, load balancing, and grayscale traffic.
Which issue(s) this PR fixes:
Fixes #421
Special notes for your reviewer:
The documentation follows the existing structure and includes both English and Chinese versions.
Does this PR introduce a user-facing change?: