Misc: ERR message polish, add missing include - #452
Closed
evelikov wants to merge 4 commits into
Closed
Conversation
Our logging macros already provide __func__ throughout. Drop the few instances which manually add it yet again. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
The other errors use zlib (the library) instead of gzip. Convert the final instance. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Swap "belch" for a more common name and use the function in all possible error paths. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
I was toying around with a home-made version of include-what-you-use, which showed that we're missing the include in a number of places. At the moment it is indirectly resolved via libkmod.h, which pulls said header for O_TRUNC and O_NONBLOCK. It's unlikely that we'll drop the include from the public header, although that doesn't mean that aiming for self-contained sources is a bad idea. For context: I am looking to remove the libkmod static link to init-module.so and part of that meant building libkmod-elf.c without the rest of kmod. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Codecov Report❌ Patch coverage is
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
Our logging macros already provide __func__ throughout. Drop the few instances which manually add it yet again. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
The other errors use zlib (the library) instead of gzip. Convert the final instance. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
Swap "belch" for a more common name and use the function in all possible error paths. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
I was toying around with a home-made version of include-what-you-use, which showed that we're missing the include in a number of places. At the moment it is indirectly resolved via libkmod.h, which pulls said header for O_TRUNC and O_NONBLOCK. It's unlikely that we'll drop the include from the public header, although that doesn't mean that aiming for self-contained sources is a bad idea. For context: I am looking to remove the libkmod static link to init-module.so and part of that meant building libkmod-elf.c without the rest of kmod. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Contributor
|
Applied, thanks |
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
Our logging macros already provide __func__ throughout. Drop the few instances which manually add it yet again. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
The other errors use zlib (the library) instead of gzip. Convert the final instance. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
Swap "belch" for a more common name and use the function in all possible error paths. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 6, 2026
I was toying around with a home-made version of include-what-you-use, which showed that we're missing the include in a number of places. At the moment it is indirectly resolved via libkmod.h, which pulls said header for O_TRUNC and O_NONBLOCK. It's unlikely that we'll drop the include from the public header, although that doesn't mean that aiming for self-contained sources is a bad idea. For context: I am looking to remove the libkmod static link to init-module.so and part of that meant building libkmod-elf.c without the rest of kmod. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #452 Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.