cleanup: drop the usage of pkg/tracing - #664
Merged
knative-prow[bot] merged 1 commit intoAug 7, 2025
Merged
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/XS
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 26.65% 26.69% +0.03%
==========================================
Files 44 44
Lines 2776 2772 -4
==========================================
Hits 740 740
+ Misses 1978 1974 -4
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
Cali0707
added a commit
to Cali0707/eventing-natss
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow Bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
* chore: update deps Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: tests use WithObservabilityConfig instead of WithTracingConfig Signed-off-by: Calum Murray <cmurray@redhat.com> * chore: bump knative version in e2e tests so that correct observability cm is deployed Signed-off-by: Calum Murray <cmurray@redhat.com> * add an empty go.mod to third_party * cleanup: drop the usage of pkg/tracing (#664) Signed-off-by: Calum Murray <cmurray@redhat.com> * Update community files (#666) Signed-off-by: Knative Automation <automation@knative.team> * chore: update codegen Signed-off-by: Calum Murray <cmurray@redhat.com> --------- Signed-off-by: Calum Murray <cmurray@redhat.com> Signed-off-by: Knative Automation <automation@knative.team> Co-authored-by: Dave Protasowski <dprotaso@gmail.com> Co-authored-by: Knative Automation <automation@knative.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes unnecessary code as tracing is already set up in sharedmain