Skip to content

[release-1.18] remove orphaned subscribers from nats jetstream channels - #685

Merged
knative-prow[bot] merged 8 commits into
knative-extensions:release-1.18from
knative-prow-robot:cherry-pick-679-to-release-1.18
Sep 11, 2025
Merged

[release-1.18] remove orphaned subscribers from nats jetstream channels#685
knative-prow[bot] merged 8 commits into
knative-extensions:release-1.18from
knative-prow-robot:cherry-pick-679-to-release-1.18

Conversation

@knative-prow-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #679

Reconclier now can remove non-existing subscriptions.

@knative-prow
knative-prow Bot requested review from matzew and pierDipi September 11, 2025 13:56
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2025
@knative-prow-robot
knative-prow-robot force-pushed the cherry-pick-679-to-release-1.18 branch from 9910519 to eae776e Compare September 11, 2025 13:56
@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.94444% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.39%. Comparing base (1ffa71b) to head (eae776e).
⚠️ Report is 1 commits behind head on release-1.18.

Files with missing lines Patch % Lines
pkg/channel/jetstream/dispatcher/reconciler.go 7.69% 59 Missing and 1 partial ⚠️
pkg/channel/jetstream/dispatcher/controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.18     #685      +/-   ##
================================================
- Coverage         26.86%   26.39%   -0.47%     
================================================
  Files                45       45              
  Lines              2721     2788      +67     
================================================
+ Hits                731      736       +5     
- Misses             1933     1994      +61     
- Partials             57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso

Copy link
Copy Markdown
Contributor

/lgtm
/override "codecov/patch"

@knative-prow

knative-prow Bot commented Sep 11, 2025

Copy link
Copy Markdown

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/patch

Details

In response to this:

/lgtm
/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@dprotaso

Copy link
Copy Markdown
Contributor

/approve

@knative-prow

knative-prow Bot commented Sep 11, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@knative-prow
knative-prow Bot merged commit 29e4f20 into knative-extensions:release-1.18 Sep 11, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants