Skip to content

Avoid no-op NATS Broker ingress contract updates - #797

Merged
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
kahirokunn:fix/ingress-contract-idempotency
Aug 30, 2026
Merged

Avoid no-op NATS Broker ingress contract updates#797
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
kahirokunn:fix/ingress-contract-idempotency

Conversation

@kahirokunn

Copy link
Copy Markdown
Member

Why

Broker reconciliation rewrote the shared ingress contract and emitted an update event even when the semantic contract was unchanged. That creates unnecessary API traffic and self-induced reconciles.

Proposed Changes

  • Skip ConfigMap writes and update events when the Broker ingress contract is unchanged.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2026
@knative-prow
knative-prow Bot requested review from Leo6Leo and dan-j August 14, 2026 02:18
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.66%. Comparing base (2c86680) to head (af2102d).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/broker/contract/manager.go 63.63% 4 Missing ⚠️
pkg/broker/controller/reconciler.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   43.50%   43.66%   +0.15%     
==========================================
  Files          68       68              
  Lines        4259     4271      +12     
==========================================
+ Hits         1853     1865      +12     
  Misses       2282     2282              
  Partials      124      124              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn

Copy link
Copy Markdown
Member Author

/ok-to-test

@knative-prow knative-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 14, 2026
@kahirokunn

Copy link
Copy Markdown
Member Author

@astelmashenko Hi ✋ I tested it manually on my local environment and it worked fine. I would appreciate it if you could review the PR when you have time. Thank you 🙏

@astelmashenko

Copy link
Copy Markdown
Member

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2026
@knative-prow

knative-prow Bot commented Aug 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2026
@knative-prow
knative-prow Bot merged commit fa5b342 into knative-extensions:main Aug 30, 2026
21 checks passed
@astelmashenko

Copy link
Copy Markdown
Member

/cherry-pick release-1.22

@astelmashenko

Copy link
Copy Markdown
Member

/cherry-pick release-1.23

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@astelmashenko: new pull request created: #806

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot

Copy link
Copy Markdown
Contributor

@astelmashenko: new pull request created: #807

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants