Avoid no-op NATS Broker ingress contract updates - #797
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 43.50% 43.66% +0.15%
==========================================
Files 68 68
Lines 4259 4271 +12
==========================================
+ Hits 1853 1865 +12
Misses 2282 2282
Partials 124 124 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
@astelmashenko Hi ✋ I tested it manually on my local environment and it worked fine. I would appreciate it if you could review the PR when you have time. Thank you 🙏 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astelmashenko, kahirokunn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.22 |
|
/cherry-pick release-1.23 |
|
@astelmashenko: new pull request created: #806 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@astelmashenko: new pull request created: #807 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why
Broker reconciliation rewrote the shared ingress contract and emitted an update event even when the semantic contract was unchanged. That creates unnecessary API traffic and self-induced reconciles.
Proposed Changes