Make the NATS Broker control plane scalable - #798
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
=======================================
Coverage 43.50% 43.50%
=======================================
Files 68 68
Lines 4259 4259
=======================================
Hits 1853 1853
Misses 2282 2282
Partials 124 124 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
@astelmashenko Hi ✋ |
|
@kahirokunn , thank you for the PR. I'm sorry, but I'm busy on this week, will try to find time on the next week to review all the PRs. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why
The shared Broker ingress handles traffic for every NATS JetStream Broker in the cluster, but its Deployment was fixed at one replica. The Broker controller already supports leader election, but the manifest also fixed its replica count and did not express a scheduling preference for additional replicas.
The manifests should keep the one-replica Kubernetes default while allowing the ingress and controller to scale independently.
Proposed Changes
Release Note