Remove unnecessary conversion webhook from RequestReply CRD - #9039
Merged
knative-prow[bot] merged 1 commit intoApr 22, 2026
Merged
Conversation
RequestReply only has a single version (v1alpha1) and was never registered in the conversion controller, so the webhook's CA bundle was never injected. This caused kube-apiserver to log x509 certificate errors when trying to reach the unconfigured webhook endpoint.
knative-prow
Bot
added
the
size/XS
knative-prow
Bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9039 +/- ##
==========================================
+ Coverage 50.50% 50.52% +0.02%
==========================================
Files 409 409
Lines 27505 27505
==========================================
+ Hits 13891 13897 +6
+ Misses 12751 12747 -4
+ Partials 863 861 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test reconciler-tests |
openshift-merge-bot Bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Apr 23, 2026
…m RequestReply CRD (#1869) * Remove unnecessary conversion webhook from RequestReply CRD (knative#9039) RequestReply only has a single version (v1alpha1) and was never registered in the conversion controller, so the webhook's CA bundle was never injected. This caused kube-apiserver to log x509 certificate errors when trying to reach the unconfigured webhook endpoint. * Run `make generate-release`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestReply only has a single version (
v1alpha1) and was never registered in the conversion controller, so the webhook's CA bundle was never injected. This caused kube-apiserver to log x509 certificate errors when trying to reach the unconfigured webhook endpoint.