docs: fix KO_DEFAULTPLATFORMS example in DEVELOPMENT.md - #9104
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9104 +/- ##
==========================================
- Coverage 51.06% 51.04% -0.02%
==========================================
Files 411 411
Lines 22130 22130
==========================================
- Hits 11300 11296 -4
- Misses 9958 9960 +2
- Partials 872 874 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
creydr
left a comment
There was a problem hiding this comment.
Thanks for fixing it @immanuwell
/ok-to-test
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, immanuwell The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
KO_DEFAULTPLATFORMSexample inDEVELOPMENT.mdlinux/amd64,linux/arm64instead oflinux/amd64, arm64koerrors out withno matching platforms in base image indexRepro
export KO_DEFAULTPLATFORMS='linux/amd64, arm64'KO_DOCKER_REPO=ko.local ko resolve -f config/tools/appender/no matching platforms in base image indexexport KO_DEFAULTPLATFORMS='linux/amd64,linux/arm64'ko resolvecommandPre-review Checklist
Release Note
Docs
n/a, repo dev docs only