Skip to content

docs: fix KO_DEFAULTPLATFORMS example in DEVELOPMENT.md - #9104

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
immanuwell:docs/fix-ko-defaultplatforms-example
Jun 8, 2026
Merged

docs: fix KO_DEFAULTPLATFORMS example in DEVELOPMENT.md#9104
knative-prow[bot] merged 1 commit into
knative:mainfrom
immanuwell:docs/fix-ko-defaultplatforms-example

Conversation

@immanuwell

@immanuwell immanuwell commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

  • fix the KO_DEFAULTPLATFORMS example in DEVELOPMENT.md
  • use linux/amd64,linux/arm64 instead of linux/amd64, arm64
  • the old command is a bit busted, ko errors out with no matching platforms in base image index

Repro

  1. export KO_DEFAULTPLATFORMS='linux/amd64, arm64'
  2. KO_DOCKER_REPO=ko.local ko resolve -f config/tools/appender/
  3. see no matching platforms in base image index
  4. export KO_DEFAULTPLATFORMS='linux/amd64,linux/arm64'
  5. rerun the same ko resolve command
  6. it works

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

None

Docs

n/a, repo dev docs only

Signed-off-by: immanuwell <pchpr.00@list.ru>
@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2026
@knative-prow

knative-prow Bot commented Jun 6, 2026

Copy link
Copy Markdown

Hi @immanuwell. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
knative-prow Bot requested review from Leo6Leo and creydr June 6, 2026 12:58
@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.04%. Comparing base (a962fa5) to head (db4bc1d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9104      +/-   ##
==========================================
- Coverage   51.06%   51.04%   -0.02%     
==========================================
  Files         411      411              
  Lines       22130    22130              
==========================================
- Hits        11300    11296       -4     
- Misses       9958     9960       +2     
- Partials      872      874       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr creydr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it @immanuwell

/ok-to-test
/lgtm

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2026
@knative-prow

knative-prow Bot commented Jun 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, immanuwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026
@knative-prow
knative-prow Bot merged commit fd4eb83 into knative:main Jun 8, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants