fix: spread vreplicas across minReplicas pods in scheduler - #9157
Merged
knative-prow[bot] merged 2 commits intoJun 17, 2026
Conversation
The autoscaler scales the StatefulSet to at least minReplicas pods, but the scheduler only placed vreplicas equal to the requested count. This meant a ConsumerGroup with 1 vreplica would only use 1 pod, leaving the other minReplicas-1 pods idle. The scheduler now inflates the placement target to max(requested, min(minReplicas, schedulablePods)) so that vreplicas are spread across all available pods when minReplicas demands it.
knative-prow
Bot
added
the
size/L
knative-prow
Bot
added
the
approved
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9157 +/- ##
==========================================
- Coverage 51.06% 51.04% -0.03%
==========================================
Files 411 411
Lines 22132 22142 +10
==========================================
Hits 11302 11302
- Misses 9958 9965 +7
- Partials 872 875 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The len(SchedulablePods) is bounded by cluster size and cannot overflow int32.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minReplicaspods, but the scheduler only placed vreplicas equal to the requested count. This meant a VPod with fewer vreplicas thanminReplicaswould only use a subset of pods, leaving the remaining pods idle.max(requested, min(minReplicas, schedulablePods))so that vreplicas are spread across all available pods whenminReplicasdemands it.