cleanup: remove vestigial kodata directories - #9227
Merged
Merged
Conversation
The kodata directories contained symlinks to .git/HEAD, .git/refs, and the repo root LICENSE. These were used by the old knative.dev/pkg/changeset package to embed git revision info into container images at build time. That package now uses Go's built-in debug.ReadBuildInfo() / vcs.revision instead, and no code reads these kodata files. Additionally, ko v0.10+ rejects symlinks that resolve outside the kodata root, so these symlinks block upgrading setup-ko from v0.9 to v0.10.
knative-prow
Bot
added
the
size/M
knative-prow
Bot
added
the
approved
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9227 +/- ##
==========================================
- Coverage 51.05% 51.05% -0.01%
==========================================
Files 411 411
Lines 22142 22142
==========================================
- Hits 11305 11304 -1
- Misses 9961 9964 +3
+ Partials 876 874 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kodata/directories fromcmd/— they contained only symlinks (HEAD,refs,LICENSE) pointing outside the kodata rootknative.dev/pkg/changesetpackage no longer reads these files; it uses Go's built-indebug.ReadBuildInfo()/vcs.revisioninsteadsetup-kofrom v0.9 to v0.10 (see build(deps): bump the github-actions group across 1 directory with 4 updates #9225)