Skip to content

Fix linter deprecation warnings #3335

Merged
knative-prow[bot] merged 2 commits intoknative:mainfrom
dprotaso:fix-linter-rule
Mar 17, 2026
Merged

Fix linter deprecation warnings #3335
knative-prow[bot] merged 2 commits intoknative:mainfrom
dprotaso:fix-linter-rule

Conversation

@dprotaso
Copy link
Copy Markdown
Member

  • change regexp to ignore all uses of SimpleClientset
  • drop use of deprecated otelhttp.WithMetricAttributesFn

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 16, 2026
@knative-prow knative-prow bot requested review from Cali0707 and skonto March 16, 2026 21:48
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@dprotaso
Copy link
Copy Markdown
Member Author

/assign @linkvt

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.85%. Comparing base (b3fe2e5) to head (76e46dd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
- Coverage   74.88%   74.85%   -0.04%     
==========================================
  Files         189      189              
  Lines        8287     8347      +60     
==========================================
+ Hits         6206     6248      +42     
- Misses       1842     1854      +12     
- Partials      239      245       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@linkvt linkvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@knative-prow knative-prow bot merged commit 91e1768 into knative:main Mar 17, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants