Prevent heap overflow in channel-pair reconstruction#217
Merged
fabiangreffrath merged 1 commit intoknik0:masterfrom Mar 25, 2026
Merged
Prevent heap overflow in channel-pair reconstruction#217fabiangreffrath merged 1 commit intoknik0:masterfrom
fabiangreffrath merged 1 commit intoknik0:masterfrom
Conversation
allocate_channel_pair() previously only allocated time_out/fb_intermed when NULL, which could leave a stale undersized time_out buffer when SBR becomes active after element reallocation. Always free and reallocate these buffers based on the current SBR state to prevent out-of-bounds writes during SBR QMF synthesis.
fabiangreffrath
approved these changes
Mar 25, 2026
Collaborator
fabiangreffrath
left a comment
fabiangreffrath
left a comment
There was a problem hiding this comment.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a security bug in the SBR QMF synthesis path where a channel-pair element could keep a stale, undersized
time_outbuffer after reallocation. In that state, SBR synthesis can write past the end of the heap buffer.The fix makes
allocate_channel_pair()always free and reallocatetime_outandfb_intermedbased on the current upsampling state to prevent the OOB write.