Skip to content

fix(SC3001): do not warn about process substitution in the case of busybox sh #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-kwsm wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

fix(SC3001): do not warn about process substitution in the case of busybox sh #3504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ShellCheck/Checks/ShellSupport.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ prop_checkBashisms147 = verify checkBashisms "[ -R ref ]" -- SC3063
prop_checkBashisms148 = verify checkBashisms "[ -N file ]" -- SC3064
prop_checkBashisms149 = verify checkBashisms "[ -G file ]" -- SC3066
prop_checkBashisms150 = verify checkBashisms "[ -O file ]" -- SC3067
prop_checkBashisms151 = verifyNot checkBashisms "#!/bin/busybox sh\npwd | tee >(gzip > log.gz)" -- SC3001
checkBashisms = ForShell [Sh, Dash, BusyboxSh] $ \t -> do
params <- ask
kludge params t
Expand All @@ -260,7 +261,7 @@ checkBashisms = ForShell [Sh, Dash, BusyboxSh] $ \t -> do
else warn id code $ "In POSIX sh, " ++ s ++ " undefined."
asStr = getLiteralString

bashism (T_ProcSub id _ _) = warnMsg id 3001 "process substitution is"
bashism (T_ProcSub id _ _) = unless isBusyboxSh $ warnMsg id 3001 "process substitution is"
bashism (T_Extglob id _ _) = warnMsg id 3002 "extglob is"
bashism (T_DollarDoubleQuoted id _) = warnMsg id 3004 "$\"..\" is"
bashism (T_ForArithmetic id _ _ _ _) = warnMsg id 3005 "arithmetic for loops are"
Expand Down
Loading