Skip to content

Accept an escaped ! as negation in [ ] test expressions #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eljees wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Accept an escaped ! as negation in [ ] test expressions #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ShellCheck/Analytics.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1710,6 +1710,7 @@ prop_checkValidCondOps2 = verify checkValidCondOps "[ -M a ]"
prop_checkValidCondOps2a = verifyNot checkValidCondOps "[ 3 \\> 2 ]"
prop_checkValidCondOps3 = verifyNot checkValidCondOps "[ 1 = 2 -a 3 -ge 4 ]"
prop_checkValidCondOps4 = verifyNot checkValidCondOps "[[ ! -v foo ]]"
prop_checkValidCondOps5 = verifyNot checkValidCondOps "[ \\! -e foo ]"
checkValidCondOps _ (TC_Binary id _ s _ _)
| s `notElem` binaryTestOps =
warn id 2057 "Unknown binary operator."
Expand Down
3 changes: 2 additions & 1 deletion src/ShellCheck/Parser.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ readConditionContents single =

readCondNot = do
start <- startSpan
char '!'
if single then void (try (readRegularOrEscaped (string "!"))) else void (char '!')
id <- endSpan start
spacingOrLf
expr <- readCondExpr
Expand Down Expand Up @@ -947,6 +947,7 @@ prop_readCondition26 = isOk readScript "[[ foo ]]\\\n && bar"
prop_readCondition27 = not $ isOk readConditionCommand "[[ x ]] foo"
prop_readCondition28 = isOk readCondition "[[ x = [\"$1\"] ]]"
prop_readCondition29 = isOk readCondition "[[ x = [*] ]]"
prop_readCondition30 = isOk readCondition "[ \\! \\( -e foo -a -e bar \\) ]"

readCondition = called "test expression" $ do
opos <- getPosition
Expand Down
Loading