Skip to content

openapi-request-validator: Fix componentSchemas type (fixes #820) - #821

Open
aldex32 wants to merge 1 commit into
kogosoftwarellc:mainfrom
aldex32:master
Open

openapi-request-validator: Fix componentSchemas type (fixes #820)#821
aldex32 wants to merge 1 commit into
kogosoftwarellc:mainfrom
aldex32:master

Conversation

@aldex32

@aldex32 aldex32 commented Jul 8, 2022

Copy link
Copy Markdown

No description provided.

@jsdevel

jsdevel commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

thanks @aldex32 . i believe this is technically a breaking change correct?

@aldex32

aldex32 commented Jul 8, 2022

Copy link
Copy Markdown
Author

Hey @jsdevel , yes it is a breaking change.
I can avoid it buy making it backward compatible like this:

  componentSchemas?: IJsonSchema[] | { [key: string]: OpenAPIV3.ReferenceObject | OpenAPIV3.SchemaObject; };

But I am not sure if the type IJsonSchema[] is/was correct. Also all the tests I see in this project are not assigning any array to this field. Unfortunately the tests are not type checking the arguments passed to the constructor of OpenAPIRequestValidator and this probably was the reason of not catching the wrong type.

@jsdevel

jsdevel commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@aldex32 breaking change doesn't scare me. is this in line with th OpenAPI schema?

@jsdevel

jsdevel commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

@aldex32 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants