Skip to content

refactor(gh-790): update dependencies and APIs for latest flowMC v0.6.1#853

Merged
Qazalbash merged 2 commits into
devfrom
issue-790
Jun 26, 2026
Merged

refactor(gh-790): update dependencies and APIs for latest flowMC v0.6.1#853
Qazalbash merged 2 commits into
devfrom
issue-790

Conversation

@Qazalbash

Copy link
Copy Markdown
Member

Summary

Update dependencies and APIs for the latest flowMC v0.6.1

Related To

@Qazalbash Qazalbash self-assigned this Jun 26, 2026
@Qazalbash Qazalbash added the internal An internal refactor or improvement label Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the flowmc dependency to version 0.6.1 and replaces the custom _HMC implementation with the native HMC sampler from flowMC. As part of this migration, references to mass_matrix have been renamed to condition_matrix across the codebase, and a new Pydantic validator has been added. The review feedback highlights opportunities to improve robustness: validating the shape of condition_matrix against n_dims to prevent JAX shape mismatches, removing unreachable list-checking code in the Pydantic validator, and raising an error in diag_condition_matrix.py if any computed variance is zero or negative.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/gwkokab/analysis/core/flowMC_base.py
Comment thread src/gwkokab/analysis/core/inference_io/_sampler.py Outdated
Comment thread src/gwkokab_scripts/diag_condition_matrix.py
@Qazalbash Qazalbash changed the base branch from main to dev June 26, 2026 18:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Qazalbash Qazalbash merged commit c1af8c2 into dev Jun 26, 2026
5 checks passed
@Qazalbash Qazalbash deleted the issue-790 branch June 26, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update API for flowMC>=0.5.0

1 participant