fix mishandling of ^ inside an expression#61
Open
marler8997 wants to merge 1 commit intokokke:masterfrom
Open
Conversation
cce085a to
964b93a
Compare
Author
|
ping @kokke, if you have time I'd like to get some of the trivial PRs reviewed. This one is a single-line bug fix to the implementation along with some additional testing. Another trivial bug fix is #64 If you review/merge these 2 PRs, I can then maybe try to identify the other bugs that are preventing the random tests from working so we can enforce that they pass on the CI (see #66). Getting the tests working again is the first thing I'd like to help with since it's the sure fire way to enforce that any other changes are correct. |
matyalatte
added a commit
to matyalatte/tiny-str-match
that referenced
this pull request
Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a
^character appears inside a regex pattern and is neither the first character of the expression nor the first character in a character class, then it will be "compiled" to aBEGINobject, but will be interpreted by the pattern matching code as aCHARobject (in thematchonefunction). This means it will try to match the text against theBEGINobjectsu.chfield which will be uninitialized memory.For the fix I checked what the Python regex implementation did in this case, it appears that it does not match the
^character inside an expression, here's some python code that demonstrates this:Along with the fix I also added a regression test that ensures that
a^never matches any sequence of two characters starting witha.