Skip to content

🐛 removing references to my fork's actions/workflows#193

Merged
shawn-hurley merged 2 commits into
mainfrom
bugfix/remove-wrong-references
Feb 18, 2026
Merged

🐛 removing references to my fork's actions/workflows#193
shawn-hurley merged 2 commits into
mainfrom
bugfix/remove-wrong-references

Conversation

@shawn-hurley

@shawn-hurley shawn-hurley commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Updated CI/nightly workflows to use a different build and test provider and to set the Go toolchain to 1.25.
    • Preserved existing inputs and overall build/test behavior.
  • Impact

    • No user-visible changes; existing functionality and build outcomes remain the same.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
@shawn-hurley shawn-hurley marked this pull request as ready for review February 18, 2026 19:44
@coderabbitai

coderabbitai Bot commented Feb 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Updated two GitHub workflow files: .github/workflows/build-nightly-images.yaml now adds a "Setup golang" step and switches the build-image action to konveyor/ci/build-image@main; .github/workflows/nightly-koncur.yaml replaces the koncur-kantra action with konveyor/ci/koncur-kantra@main.

Changes

Cohort / File(s) Summary
Nightly images workflow
.github/workflows/build-nightly-images.yaml
Added a "Setup golang" step using actions/setup-go@v6 (go-version: '1.25') and replaced shawn-hurley/ci/build-image@main with konveyor/ci/build-image@main.
Koncur testing workflow
.github/workflows/nightly-koncur.yaml
Switched the koncur-kantra action from shawn-hurley/ci/koncur-kantra@main to konveyor/ci/koncur-kantra@main (inputs unchanged).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A rabbit hops through CI tonight,
Swapping names with nimble delight,
Go gets set, actions find new home,
Pipelines hum as changes roam,
Carrots in logs, all tests take flight 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: removing references to the author's fork (shawn-hurley) and replacing them with the main organization repository (konveyor).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix/remove-wrong-references

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.github/workflows/build-nightly-images.yaml (1)

65-65: Consider SHA pinning for @main — same rationale as koncur-kantra.

konveyor/ci/build-image@main is mutable. Pinning to a specific commit SHA ensures nightly image builds are reproducible and not inadvertently broken by unrelated changes to the build-image action in the same repo.

💡 Example with SHA pinning
-        uses: konveyor/ci/build-image@main
+        uses: konveyor/ci/build-image@<SHA>  # main as of YYYY-MM-DD
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-nightly-images.yaml at line 65, The workflow uses
the mutable action reference konveyor/ci/build-image@main which risks
non-reproducible/nightly breaks; replace the `@main` tag with a specific commit
SHA for konveyor/ci/build-image (e.g., konveyor/ci/build-image@<commit-sha>) so
the workflow pins to an immutable revision—update the uses line that currently
contains konveyor/ci/build-image@main to the chosen commit SHA and commit the
change.
.github/workflows/nightly-koncur.yaml (1)

164-164: Consider pinning to a SHA instead of @main for stability.

Using @main is a mutable reference — any commit to konveyor/ci:main can silently alter this action's behavior. For a CI action used in nightly runs, pinning to a specific SHA (with a comment tracking the intended version) gives a reproducible, auditable reference and prevents unexpected breakage.

💡 Example with SHA pinning
-        uses: konveyor/ci/koncur-kantra@main
+        uses: konveyor/ci/koncur-kantra@<SHA>  # main as of YYYY-MM-DD
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/nightly-koncur.yaml at line 164, Replace the mutable tag
on the GitHub Action usage to a specific commit SHA to ensure reproducible runs:
change the uses entry "konveyor/ci/koncur-kantra@main" to
"konveyor/ci/koncur-kantra@<commit-sha>" (use the SHA of the intended
release/commit) and add a short comment noting the chosen SHA and why it was
pinned; update any workflow documentation or PR description to record the pinned
version for future updates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/build-nightly-images.yaml:
- Line 65: The workflow uses the mutable action reference
konveyor/ci/build-image@main which risks non-reproducible/nightly breaks;
replace the `@main` tag with a specific commit SHA for konveyor/ci/build-image
(e.g., konveyor/ci/build-image@<commit-sha>) so the workflow pins to an
immutable revision—update the uses line that currently contains
konveyor/ci/build-image@main to the chosen commit SHA and commit the change.

In @.github/workflows/nightly-koncur.yaml:
- Line 164: Replace the mutable tag on the GitHub Action usage to a specific
commit SHA to ensure reproducible runs: change the uses entry
"konveyor/ci/koncur-kantra@main" to "konveyor/ci/koncur-kantra@<commit-sha>"
(use the SHA of the intended release/commit) and add a short comment noting the
chosen SHA and why it was pinned; update any workflow documentation or PR
description to record the pinned version for future updates.

Signed-off-by: Shawn Hurley <shawn@hurley.page>
@shawn-hurley shawn-hurley merged commit 368e6ff into main Feb 18, 2026
108 of 109 checks passed
@mguetta1 mguetta1 deleted the bugfix/remove-wrong-references branch June 9, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants