Skip to content

[RFR] Disable tests that are duplicated in Koncur#148

Open
ibragins wants to merge 1 commit into
konveyor:mainfrom
ibragins:disable_overlapping_tests
Open

[RFR] Disable tests that are duplicated in Koncur#148
ibragins wants to merge 1 commit into
konveyor:mainfrom
ibragins:disable_overlapping_tests

Conversation

@ibragins

@ibragins ibragins commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Reorganized test suite to eliminate redundant test coverage by skipping tests that are covered by other test suites.

Signed-off-by: Igor Braginsky <ibragins@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a2279cc8-dd13-4f2a-b4b6-d08c072e011a

📥 Commits

Reviewing files that changed from the base of the PR and between b2b6263 and 3868d39.

📒 Files selected for processing (4)
  • tests/analysis/java/test_analysis.py
  • tests/analysis/java/test_selective_java_provider.py
  • tests/analysis/java/test_tier0.py
  • tests/analysis/python/test_python_analysis.py

📝 Walkthrough

Walkthrough

This PR marks test execution as skipped across four test modules (test_analysis.py, test_selective_java_provider.py, test_tier0.py, test_python_analysis.py). Some tests use conditional runtime skips for specific test cases, while others use function-level decorators to skip entire tests. All skips indicate coverage by koncur test suites.

Changes

Test Coverage Deduplication

Layer / File(s) Summary
Conditional case skips in parameterized Java tests
tests/analysis/java/test_analysis.py, tests/analysis/java/test_tier0.py
test_bvp_issue_analyzer_901 and test_analysis add early pytest.skip() guards that match specific parameterized cases against module-level sets (_KONCUR_DUPLICATED_CASES, _KONCUR_DUPLICATED_TIER0) and skip when found.
Function-level skip decorators and imports
tests/analysis/java/test_selective_java_provider.py, tests/analysis/python/test_python_analysis.py
pytest is imported and @pytest.mark.skip decorators are added to test_java_provider_analysis and test_python_analysis_with_rules, marking them as bypassed because they are covered by koncur tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The tests once ran and ran so wide,
But koncur swept them to the side,
Now skips and guards keep duplicates tame,
One suite to rule them all, the same! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: disabling tests that duplicate functionality already covered by Koncur tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ibragins ibragins requested review from eemcmullan and jmle June 11, 2026 12:06

@jmle jmle left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's check those errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants