Skip to content

✨ Add Spring 6 Migration Rules#339

Closed
dymurray wants to merge 0 commit into
konveyor:mainfrom
dymurray:spring-migration
Closed

✨ Add Spring 6 Migration Rules#339
dymurray wants to merge 0 commit into
konveyor:mainfrom
dymurray:spring-migration

Conversation

@dymurray

@dymurray dymurray commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Issues Addressed (11)

┌───────┬────────────────────────────────────┬─────────────────────────┐ 
│ Issue │ Title                              │ Rule ID(s)              │ 
├───────┼────────────────────────────────────┼─────────────────────────┤ 
│ #134  │ RPC-style remoting removed         │ removed-apis-00010      │ 
│ #135  │ Dedicated EJB access removed       │ removed-apis-00020      │ 
│ #137  │ Bean handling annotations          │ core-container-00040    │ 
│       │ (@Inject)                          │                         │ 
│ #139  │ LocalVariableTableParameterNameDis │ core-container-00050    │ 
│       │ coverer                            │                         │ 
│ #146  │ JDBC exception translator          │ data-access-00050       │ 
│ #147  │ Deprecated exceptions              │ data-access-00040       │ 
│ #149  │ Web server upgrade                 │ web-applications-00090  │ 
│ #150  │ Dropped servlet integrations       │ web-applications-00050/ │ 
│       │                                    │ 60/70                   │ 
│ #155  │ Servlet mocks                      │ web-applications-00080  │ 
│ #167  │ Hibernate Validator 7.0            │ data-access-00060       │ 
│ #175  │ Apache HttpClient 4→5              │ httpclient-00010/20     │ 
└───────┴────────────────────────────────────┴─────────────────────────┘ 

Fixes #134 , #135, #137, #139, #146, #147, #149, #150, #155, #167, #175

Summary by CodeRabbit

  • Documentation
    • Added comprehensive tracking documentation for a migration initiative, cataloging unaddressed issues, issues resolved through existing or new rules, and parent/tracking issues. Includes detailed tables and summary statistics on overall progress, coverage status, and assignment information.

@coderabbitai

coderabbitai Bot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4eb6e2e and d0ca4b6.

⛔ Files ignored due to path filters (9)
  • default/generated/spring-framework/spring-framework-5.x-to-6.0-core-container.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/spring-framework-5.x-to-6.0-httpclient.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/spring-framework-5.x-to-6.0-removed-apis.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/spring-framework-5.x-to-6.0-web-applications.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/tests/data/web-applications/pom.xml is excluded by !**/generated/**
  • default/generated/spring-framework/tests/data/web-applications/src/main/java/org/konveyor/Main.java is excluded by !**/generated/**
  • default/generated/spring-framework/tests/spring-framework-5.x-to-6.0-httpclient.test.yaml is excluded by !**/generated/**
  • default/generated/spring-framework/tests/spring-framework-5.x-to-6.0-web-applications.test.yaml is excluded by !**/generated/**
📒 Files selected for processing (1)
  • SPRING_MIGRATION_UNADDRESSED.md

📝 Walkthrough

Walkthrough

A new Markdown document, SPRING_MIGRATION_UNADDRESSED.md, is added to list and categorize unaddressed issues for spring-migration/6, including issues assigned to others, issues covered by rules, parent/tracking issues, and summary counts.

Changes

Cohort / File(s) Summary
Documentation & Issue Tracking
SPRING_MIGRATION_UNADDRESSED.md
Adds a new file cataloging unaddressed spring-migration/6 issues: tables for issues assigned to others, issues already covered by existing/new rules, parent/tracking issues, and a final summary with counts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny rabbit notes with cheer,
Unaddressed items now appear.
Tables lined up, neat and true,
A roadmap ready — hop on through! 🥕✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only adds a markdown documentation file listing unaddressed issues without implementing the actual migration rules. The linked issue #134 requires creating detection rules with code examples and migration guidance, which are not present. Implement the actual Spring 6 migration rules (removed-apis, core-container, data-access, web-applications, httpclient rules) with proper rule descriptions, user messages, and code examples as required by the linked issues.
Out of Scope Changes check ⚠️ Warning The SPRING_MIGRATION_UNADDRESSED.md file documents a catalog of unaddressed issues rather than implementing the migration rules themselves, which is not directly within the stated scope of adding Spring 6 migration rules. Remove or clarify the purpose of the documentation file, and focus the PR on implementing the actual migration rules mentioned in the PR objectives instead of cataloging unaddressed work.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add Spring 6 Migration Rules' is directly related to the changeset which adds a documentation file cataloging Spring migration issues. It accurately summarizes the main purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this to 🆕 New in Planning Jan 20, 2026
@dymurray dymurray moved this from 🆕 New to 🏗 In progress in Planning Jan 20, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@SPRING_MIGRATION_UNADDRESSED.md`:
- Around line 29-34: Update the summary paragraph that currently reads "Issues
already assigned/covered: 11" to split it into two distinct counts (e.g.,
"Issues already assigned: N" and "Issues already covered: M") and adjust the
"Total issues with spring-migration/6" and "Issues addressed in this PR" numbers
as needed to reflect the new categorization; specifically locate the line
containing the literal text "Issues already assigned/covered: 11" and replace it
with separate labeled counts and ensure the overall totals are consistent with
those new values.
- Around line 5-22: Update the "## Already Assigned to Other Contributors"
section to separate truly assigned issues from those already covered: create two
subsections ("Issues assigned to other contributors" containing `#145` and `#152`
with their "In progress by assignee" notes, and "Issues already covered" listing
`#133`, `#136`, `#138`, `#144`, `#148`, `#151`, `#156`, `#166` with their "Already covered by
..." notes), update the table headers/rows accordingly and ensure the section
title and Notes column text accurately reflect which issues are in-progress vs.
already addressed.

Comment thread SPRING_MIGRATION_UNADDRESSED.md Outdated
Comment thread SPRING_MIGRATION_UNADDRESSED.md Outdated
@dymurray dymurray changed the title ✨ Add rules for deprecated Spring 6 data access exceptions ✨ Add Spring 6 Migration Rules Jan 20, 2026
Comment thread stable/java/spring-framework/spring-framework-5.x-to-6.0-core-container.yaml Outdated
Comment thread default/generated/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Outdated
Comment thread stable/java/spring-framework/spring-framework-5.x-to-6.0-data-access.yaml Outdated
Comment thread default/generated/spring-framework/spring-framework-5.x-to-6.0-httpclient.yaml Outdated
Comment thread default/generated/spring-framework/spring-framework-5.x-to-6.0-httpclient.yaml Outdated
Comment thread default/generated/spring-framework/spring-framework-5.x-to-6.0-removed-apis.yaml Outdated
Comment thread stable/java/spring-framework/spring-framework-5.x-to-6.0-web-applications.yaml Outdated
@dymurray dymurray self-assigned this Jan 20, 2026
@jmle jmle closed this Feb 25, 2026
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Planning Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create rules for Removed APIs: RPC-style remoting removed

2 participants