Update IP address regex pattern in hardcoded IP find rule#374
Update IP address regex pattern in hardcoded IP find rule#374GregJohnStewart wants to merge 2 commits into
Conversation
Signed-off-by: Greg Stewart <contact@gjstewart.net>
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@stable/java/00-discovery/0.yaml`:
- Line 37: The builtin.filecontent pattern currently uses an unquoted regex with
unescaped dots; update the pattern value for builtin.filecontent to follow the
repo convention by quoting the regex string and escaping literal dots (e.g.,
replace \b\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\b with a quoted version where each
dot is escaped) so the pattern is a proper quoted/escaped string; locate the
pattern entry for builtin.filecontent in the YAML (the line containing
\b\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\b) and change it to the quoted, escaped
regex form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 08f70260-fddb-4e18-b717-3484cb796758
📒 Files selected for processing (1)
stable/java/00-discovery/0.yaml
jmle
left a comment
There was a problem hiding this comment.
@GregJohnStewart thanks for the contribution! I think it looks good, but I need to double check the rule tests, which are broken atm. I will come back to this asap.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
|
Still relevant |
The original IP regex pattern was not as specific; it would trigger on valid dates formatted like
yy.mm.dd.MMMMMM.Summary by CodeRabbit