🐛 fix broken JBoss EAP 6 messaging configuration link#376
Open
mvanhorn wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (57)
✅ Files skipped from review due to trivial changes (53)
📝 WalkthroughWalkthroughReplaced legacy access.redhat.com documentation URLs with docs.redhat.com equivalents across many Windup/YAML rule files; only ChangesDocumentation Link Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves konveyor#344. The Messaging Configuration link in rule jboss-eap5-java-02000 returned a 404 after Red Hat's documentation portal migrated from `access.redhat.com` to `docs.redhat.com`. Verified: ``` $ curl -sIL 'https://access.redhat.com/.../JBoss_Enterprise_Application_Platform/6.4/html/Administration_and_Configuration_Guide/sect-Configuration1.html' ... HTTP/2 301 -> docs.redhat.com -> HTTP/2 404 ``` The `html-single` (one-page) version of the same Administration and Configuration Guide on the new portal returns 200 and preserves the `#Configure_the_JMS_Server1` anchor: ``` $ curl -sIL 'https://docs.redhat.com/en/documentation/red_hat_jboss_enterprise_application_platform/6.4/html-single/administration_and_configuration_guide/index#Configure_the_JMS_Server1' ... HTTP/2 200 ``` And the anchor is present in the page source: ``` id="sub-link-to-administration_and_configuration_guide-Configure_the_JMS_Server1" ``` Scope is intentionally limited to the link in the issue. Other rule files reference the same access.redhat.com path pattern; those can be swept in a follow-up if the maintainers want a single bulk migration. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
mvanhorn
force-pushed
the
osc/344-fix-jboss-eap-broken-link
branch
from
c3d7104 to
b68ead4
Compare
Contributor
|
Hey @mvanhorn , thanks for you contribution!
Please feel free to modify those too if they need to. This one looks good, but I'm going to put merging on hold in case you want to bulk it. |
Bulk pass following the same pattern as the original JBoss EAP 6 messaging
fix in this PR. 172 access.redhat.com/documentation URLs across 57 files
were rewritten to docs.redhat.com using the verified pattern:
access.redhat.com/documentation/en-us/<product>/<version>/{html,html-single}/<book>/...
-> docs.redhat.com/en/documentation/<product_lowercase>/<version>/html-single/<book>/index<anchor>
70 URLs were skipped: /articles/ and /solutions/ paths don't have predictable
docs.redhat.com replacements, so they were left unchanged.
Per @jmle review comment on PR konveyor#376.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Pushed 70 URLs were left alone: Couldn't run live HEAD verification on every URL - Red Hat's docs site returns 403 to bare curl regardless of host. The pattern matches the shape you confirmed in Ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #344. The Messaging Configuration link in rule
jboss-eap5-java-02000(understable/java/eap6/84-jboss-eap5-java.windup.yaml) returned a 404 after Red Hat migrated their documentation portal fromaccess.redhat.comtodocs.redhat.com. This swaps the URL to the workinghtml-singleversion of the same guide.Why this matters
The link is the primary remediation reference operators see when this rule fires during a Windup migration scan. A broken link strips the actionable context that makes the rule useful.
I verified the failure mode and the fix end-to-end:
The
Configure_the_JMS_Server1anchor is preserved in the new page (grepagainst the rendered HTML returnsid="sub-link-to-administration_and_configuration_guide-Configure_the_JMS_Server1"), so the deep-link still lands operators on the JMS Server configuration section.Changes
stable/java/eap6/84-jboss-eap5-java.windup.yaml: update theJBoss EAP 6 - Messaging Configurationlink to the newdocs.redhat.comhtml-singleURL.Scope note
I deliberately limited the diff to the specific link the issue calls out. A
grep -rln 'access.redhat.com/documentation/en-us/JBoss_Enterprise_Application_Platform/6.4'shows five rule files referencing the same domain pattern (stable/java/eap{6,7}/...); those probably need the same migration but treating that as a separate sweep keeps this PR focused on the issue's exact ask. Happy to do the bulk pass as a follow-up if the maintainers prefer.Testing
python3 -c "import yaml; yaml.safe_load(open('stable/java/eap6/84-jboss-eap5-java.windup.yaml'))"— YAML still valid.curl -sIL(200 OK + anchor present) before commit.Fixes #344
Summary by CodeRabbit