address copilot comments, fix copyright

Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>

controllers/functionconfigs/reconciler.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

controllers/functionconfigs/store.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -22,8 +22,8 @@ import (
 	"strings"
 	"sync"
 
-	"github.com/kptdev/krm-functions-catalog/functions/go/apply-replacements/replacements"
-	"github.com/kptdev/krm-functions-catalog/functions/go/set-namespace/transformer"
+	applyreplacements "github.com/kptdev/krm-functions-catalog/functions/go/apply-replacements/replacements"
+	setnamespace "github.com/kptdev/krm-functions-catalog/functions/go/set-namespace/transformer"
 	"github.com/kptdev/krm-functions-catalog/functions/go/starlark/starlark"
 	"github.com/kptdev/krm-functions-sdk/go/fn"
 	configapi "github.com/kptdev/porch/api/porchconfig/v1alpha1"
@@ -61,8 +61,8 @@ type FunctionConfigStore struct {
 
 func NewStore(defaultImagePrefix, defaultBinaryDir string) *FunctionConfigStore {
 	procMap := map[string]fn.ResourceListProcessorFunc{
-		"apply-replacements": replacements.ApplyReplacements,
-		"set-namespace":      set_namespace.Run,
+		"apply-replacements": applyreplacements.ApplyReplacements,
+		"set-namespace":      setnamespace.Run,
 		"starlark":           starlark.Process,
 	}
 
@@ -108,7 +108,7 @@ func (s *FunctionConfigStore) Store(obj *configapi.FunctionConfig) error {
 	}
 	if strippedSpec.BinaryExecutor != nil {
 		strippedSpec.BinaryExecutor.Tags = nil
-		if strippedSpec.BinaryExecutor.Path[0] != '/' {
+		if len(strippedSpec.BinaryExecutor.Path) > 0 && strippedSpec.BinaryExecutor.Path[0] != '/' {
 			var err error
 			strippedSpec.BinaryExecutor.Path, err = filepath.Abs(filepath.Join(s.defaultBinaryDir, spec.BinaryExecutor.Path))
 			if err != nil {
@@ -175,17 +175,15 @@ func (s *FunctionConfigStore) Delete(imageName string) {
 }
 
 func (s *FunctionConfigStore) DeleteByObjName(key client.ObjectKey) {
-	toDelete := ""
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
 	for imageName, entry := range s.internalCache {
 		if entry.objName == key {
-			toDelete = imageName
-			break
+			delete(s.internalCache, imageName)
+			return
 		}
 	}
-
-	if toDelete != "" {
-		s.Delete(toDelete)
-	}
 }
 
 func (s *FunctionConfigStore) Get(fullImageName string) (configapi.FunctionConfigSpec, bool) {

controllers/functionconfigs/store_test.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

controllers/main.go

@@ -339,7 +339,7 @@ func prePopulateFunctionConfigStore(reader client.Reader, store *functionconfigs
 		obj := &fcList.Items[i]
 		err := store.Store(obj)
 		if err != nil {
-			klog.Warningf("Failed to store %q during pre-pupulate (non-fatal): %v", client.ObjectKeyFromObject(obj), err)
+			klog.Warningf("Failed to store %q during pre-populate (non-fatal): %v", client.ObjectKeyFromObject(obj), err)
 		}
 	}
 	klog.Infof("FunctionConfig store pre-populated with %d configs", len(fcList.Items))

func/types/common_types.go

@@ -91,7 +91,7 @@ type FunctionPodInfo struct {
 
 // SendResponse sends a reply to the connection request containing the pod data.
 // If err != nil it sends `err` as an error response.
-// It sends and error response if the pod is not ready yet (this shouldn't happen).
+// It sends an error response if the pod is not ready yet (this shouldn't happen).
 func (pod *FunctionPodInfo) SendResponse(responseCh chan<- *ConnectionResponse, err error) {
 	switch {
 	case err != nil:

pkg/util/image/image.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

pkg/util/image/image_test.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

pkg/util/image/types.go

@@ -1,4 +1,4 @@
-// Copyright 2026 The kpt and Nephio Authors
+// Copyright 2026 The kpt Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -16,7 +16,8 @@ package image
 
 import "strings"
 
-// ParsedImage is a
+// ParsedImage is a structured representation of a container image reference,
+// broken into registry, sub-path, base name, tag, and digest components.
 type ParsedImage struct {
 	// The registry part of the image name without trailing slash.
 	// Example: ghcr.io