Clear the status of the subpackage Kptfile on subpackage clones and upgrades - #1118
Merged
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
July 16, 2026 07:40
dosubot
Bot
added
the
size:XS
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the subpackage clone/upgrade flow to clear the status field in a subpackage’s Kptfile, ensuring the cloned/upgraded subpackage starts a fresh lifecycle instead of inheriting upstream render status (aligning with #1109).
Changes:
- Clear subpackage
Kptfilestatus during subpackage clone/upgrade before writing it into the parent package. - Update the subpackage Kptfile write path in
applySubpackageTask(with a noted error-message issue to fix).
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
Catalin-Stratulat-Ericsson
previously approved these changes
Jul 16, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
thanks for this clarity
aravindtga
previously approved these changes
Jul 16, 2026
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
dismissed stale reviews from aravindtga and Catalin-Stratulat-Ericsson
via
July 16, 2026 10:16
fae61cb
kushnaidu
previously approved these changes
Jul 16, 2026
Signed-off-by: liamfallon <liam.fallon@est.tech>
efiacor
approved these changes
Jul 16, 2026
Catalin-Stratulat-Ericsson
approved these changes
Jul 16, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
nice to have unit tests along with the change. thank you
aravindtga
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the status of the subpackage Kptfile on subpackage clones and upgrades
Description
Related Issue(s)
Type of Change
Checklist
AI Disclosure