Fix e2e function tests - #1123
Merged
Merged
Conversation
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
July 20, 2026 14:38
dosubot
Bot
added
the
size:XS
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the e2e “3rd party kpt function” test suite to stop hardcoding KRM function image versions and testdata paths, instead generating test cases from a YAML configuration file so the suite is easier to keep up to date (including temporarily skipping known-broken functions).
Changes:
- Add
test/e2e/fn_runner/testdata/function-versions.yamlto centrally define which function versions to test (latest, n-1, optional other, and skip). - Update
test/e2e/fn_runner/3rd_party_kpt_fn_test.goto load versions from that YAML and generate image test cases (absolute/relative, tagged, minor/major tags). - Fix multiple testdata resource paths used by the suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| test/e2e/fn_runner/testdata/function-versions.yaml | New YAML config defining per-function versions to test and skip flags. |
| test/e2e/fn_runner/3rd_party_kpt_fn_test.go | Refactors tests to build cases from YAML config and updates testdata file paths accordingly. |
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
mozesl-nokia
approved these changes
Jul 21, 2026
rendre-greyling
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix e2e function tests
Description
ensure-name-substringtests because theensure-name-substringkrm function is brokentest/e2e/fn_runner/testdata/function-versions.yamlfiletest/e2e/fn_runner/testdata/function-versions.yamlis added totest/e2e/fn_runner/3rd_party_kpt_fn_test.gofunction-versions.yaml3rd_party_kpt_fn_test.gofile now builds the test cases from the configuration fil.The
function-versions.yamlfile has the following structureTests of the bare krm function and the
latestversion of the KRM function are always added and tests are performed with and without the image prefix. Tests for the latest released minor default version and major default version are also generated. The configuration above will trigger tests on the following images:Type of Change
Checklist
AI Disclosure