Set subpackage mutations to always be non-deployment - #1131
Merged
Conversation
liamfallon
requested review from
efiacor,
kispaljr and
mozesl-nokia
as code owners
July 23, 2026 07:00
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
the
size:XS
liamfallon
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the subpackage task execution path so subpackage mutations are never treated as “deployment” mutations, preventing deployment context generation (e.g., package-context.yaml) from being triggered during subpackage clone/upgrade flows.
Changes:
- Hard-codes the
isDeploymentflag tofalsewhen mapping the subpackage task (obj.Spec.Tasks[1]) into a mutation. - Ensures subpackage clone no longer generates deployment context based on repository deployability settings.
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Catalin-Stratulat-Ericsson
previously approved these changes
Jul 23, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
perfect. thanks so much for taking this up. to be honest i have no idea why we would ever recreate files that dont exist in the upstream on a clone and no clue why we would do so on deployment repos but not regular ones...
liamfallon
force-pushed
the
remove-deploy-flag
branch
from
July 23, 2026 08:22
80a2e7b to
02bc047
Compare
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
|
JamesMcDermott
approved these changes
Jul 23, 2026
aravindtga
approved these changes
Jul 23, 2026
efiacor
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set subpackage mutations to always be non-deployment, only package mutations can be deployment mutations
Description
falseon subpackagecloneandupgrademutaitonscloneandupgradeshould never be deployment mutations because subpackage mutations never lead to a depplyable package revision and don't need a separatepackage-context.yaml. The main package containing the subpackages has thepackage-context-yamlresources for the entire package and that is what is deployed.Fixes: kptdev/kpt#4650
Type of Change
Checklist
AI Disclosure