Skip to content

Custom RSI XML parsing#5

Draft
pasztork wants to merge 3 commits into
masterfrom
feature/rsi-xml-parsing
Draft

Custom RSI XML parsing#5
pasztork wants to merge 3 commits into
masterfrom
feature/rsi-xml-parsing

Conversation

@pasztork

Copy link
Copy Markdown
Contributor

This PR adds all the necessary changes for the RSI messages to be configurable.

@pasztork pasztork self-assigned this Jul 13, 2026
@pasztork pasztork added the enhancement New feature or request label Jul 13, 2026
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aeecbc44-f0d3-4485-8c60-54cceac78d14

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/rsi-xml-parsing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

<xacro:arg name="pitch" default="0"/>
<xacro:arg name="yaw" default="0"/>
<xacro:kuka_agilus_ros2_control name="$(arg prefix)kr10_r1100_2_with_kl100_2" driver_version="$(arg driver_version)" client_ip="$(arg client_ip)" client_port="$(arg client_port)" mxa_client_port="$(arg mxa_client_port)" controller_ip="$(arg controller_ip)" prefix="$(arg prefix)" mode="$(arg mode)" use_gpio="$(arg use_gpio)" roundtrip_time="$(arg roundtrip_time)" verify_robot_model="$(arg verify_robot_model)">
<xacro:arg name="rsi_xml_config_file" default=""/>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also extend the launch file and pass the appropriate config file to also contain 1 external axis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants