Merged
Conversation
Walkthrough
Changes
Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/main/resources/db/migration/V260326__Drop_duplicate_club_subscribe_index.sql (1)
11-11: 인덱스 제거 후 조회 성능 회귀 여부만 배포 단계에서 확인해 주세요.
club_subscribe의club_id조건 조회가 많은 경우, 배포 후 주요 쿼리에 대해EXPLAIN으로 실행 계획을 한 번 점검해 두면 안전합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/resources/db/migration/V260326__Drop_duplicate_club_subscribe_index.sql` at line 11, 이 변경은 'ALTER TABLE club_subscribe DROP INDEX idx_club_subscribe_club'로 인덱스를 제거하므로 배포 전/후 주요 club_id 사용 쿼리들의 실행 계획과 비용을 EXPLAIN으로 비교해 성능 회귀 여부를 확인하세요; 만약 조회 성능이 악화되면 idx_club_subscribe_club을 유지하거나 더 적합한 인덱스(예: 조건에 맞춘 복합 인덱스)로 교체하도록 SQL을 준비하고, 배포 계획에 롤백/재생성 절차를 포함시켜 주세요.src/test/java/com/kustacks/kuring/club/domain/ClubTest.java (1)
16-25: 리플렉션 기반 테스트는 어노테이션 설정만 검증하며, 실제 JPA 동작을 검증하지 않습니다.현재 테스트는
@OneToMany어노테이션의 속성 값을 검증하지만, 실제 orphan removal 및 cascade 동작은 검증하지 않습니다. PR 설명에서 언급된 대로,ClubSns삭제 전파와 orphan removal이 의도대로 동작하는지 통합 테스트로 검증하는 것을 권장합니다.또한
NoSuchFieldException을 throws로 선언하면 필드명이 변경될 때 assertion 실패가 아닌 예외가 발생합니다.♻️ 예외 처리 개선 제안
`@Test` `@DisplayName`("homepageUrls는 Club이 ClubSns 생명주기를 관리하도록 설정된다") -void homepage_urls_should_manage_club_sns_lifecycle() throws NoSuchFieldException { - Field homepageUrlsField = Club.class.getDeclaredField("homepageUrls"); +void homepage_urls_should_manage_club_sns_lifecycle() { + Field homepageUrlsField; + try { + homepageUrlsField = Club.class.getDeclaredField("homepageUrls"); + } catch (NoSuchFieldException e) { + throw new AssertionError("Club 엔티티에 homepageUrls 필드가 존재하지 않습니다", e); + } OneToMany mapping = homepageUrlsField.getAnnotation(OneToMany.class);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/java/com/kustacks/kuring/club/domain/ClubTest.java` around lines 16 - 25, The reflection-based test in ClubTest only inspects the `@OneToMany` annotation (homepageUrlsField / OneToMany) and doesn't verify runtime JPA behavior for cascade/orphanRemoval; replace or supplement this unit test with an integration test that persists a Club with associated ClubSns entities, deletes or removes a ClubSns and verifies the deletion is propagated (cascade remove) and that orphan removal actually deletes the child from the DB, invoking real EntityManager/Repository operations; also remove the "throws NoSuchFieldException" pattern on the test (currently declared on homepage_urls_should_manage_club_sns_lifecycle) and instead handle failures with assertions so a renamed/removed field produces a test failure rather than an unchecked exception.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@src/main/resources/db/migration/V260326__Drop_duplicate_club_subscribe_index.sql`:
- Line 11: 이 변경은 'ALTER TABLE club_subscribe DROP INDEX
idx_club_subscribe_club'로 인덱스를 제거하므로 배포 전/후 주요 club_id 사용 쿼리들의 실행 계획과 비용을
EXPLAIN으로 비교해 성능 회귀 여부를 확인하세요; 만약 조회 성능이 악화되면 idx_club_subscribe_club을 유지하거나 더
적합한 인덱스(예: 조건에 맞춘 복합 인덱스)로 교체하도록 SQL을 준비하고, 배포 계획에 롤백/재생성 절차를 포함시켜 주세요.
In `@src/test/java/com/kustacks/kuring/club/domain/ClubTest.java`:
- Around line 16-25: The reflection-based test in ClubTest only inspects the
`@OneToMany` annotation (homepageUrlsField / OneToMany) and doesn't verify runtime
JPA behavior for cascade/orphanRemoval; replace or supplement this unit test
with an integration test that persists a Club with associated ClubSns entities,
deletes or removes a ClubSns and verifies the deletion is propagated (cascade
remove) and that orphan removal actually deletes the child from the DB, invoking
real EntityManager/Repository operations; also remove the "throws
NoSuchFieldException" pattern on the test (currently declared on
homepage_urls_should_manage_club_sns_lifecycle) and instead handle failures with
assertions so a renamed/removed field produces a test failure rather than an
unchecked exception.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad148ed7-4fd1-48de-b9c2-9bbfd62ada48
📒 Files selected for processing (3)
src/main/java/com/kustacks/kuring/club/domain/Club.javasrc/main/resources/db/migration/V260326__Drop_duplicate_club_subscribe_index.sqlsrc/test/java/com/kustacks/kuring/club/domain/ClubTest.java
Collaborator
|
수고하셨습니다!! 변경사항 확인했습니당 |
jiyun921
approved these changes
Mar 30, 2026
Member
Author
|
close #352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 이슈
📌 요약
🛠️ 상세
💬 기타
Summary by CodeRabbit
릴리스 노트
버그 수정
데이터베이스
테스트