upgrade base image to debian 13#1557
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
14e9959 to
c44dea3
Compare
|
XFS (nvme5n1): Superblock has unknown incompatible features (0x20) enabled. Looks like mkfs.xfs is too new and enabled some features that is not supported by alinux3 kernel. Available at Linux v5.19 torvalds/linux@919819f |
| } else if fstype == "xfs" { | ||
| args = []string{ | ||
| "-f", | ||
| "-i", "nrext64=0", // This requires kernel v5.19, so disable for now. |
There was a problem hiding this comment.
another reason to hold this. We will need to replace ASI dockerfile before merge. Old mkfs.xfs will not understand this flag.
Now all binaries are under /usr, we can remove the logic to search both.
There was a problem hiding this comment.
Automated Code Review
Summary: Upgrades the base container image from Debian 12 (Bookworm) to Debian 13 (Trixie), updating all dependent package versions and adjusting build scripts for filesystem layout changes (/sbin → /usr/sbin).
Issues Found:
- Path changes (
/sbin/→/usr/sbin/) forfsck,mkfs,mount,umount,resize2fs— these must match the actual filesystem layout in Debian 13. The usrmerge in Debian 13 should have symlinks, but the explicit paths are safer. - The
gccpackage addition in the build stage is well-documented with the Debian bug reference — good. - The
configurescript now dumpsconfig.logon failure — helpful for debugging cross-compilation issues. - New dependencies added:
libzstd1,zlib1g— verify these are actually needed by the runtime binaries. - Package version pinning is very specific (e.g.,
libc6 2.41-12+deb13u1). This will need updates as Debian 13 receives security patches.
Suggestions:
- Consider running the full test suite with the new base image in CI before merging to catch any subtle behavioral differences.
- The
libext2fs2t64naming (witht64suffix) is the time_t transition — this is expected for Debian 13 on 32-bit archs but verify it resolves correctly on amd64.
Overall: Straightforward base image upgrade with careful attention to Debian 13's filesystem changes. The explicit path adjustments and build toolchain fixes demonstrate good testing.
mowangdk
left a comment
There was a problem hiding this comment.
Automated Code Review
Summary: Upgrades the base image from Debian 12 (bookworm) to Debian 13 (trixie), updates all dependency versions, and adjusts paths for binaries that moved from /sbin to /usr/sbin.
Overall: Thorough upgrade with appropriate adjustments for the new filesystem layout. One concern about the xfs flag.
| } else if fstype == "xfs" { | ||
| args = []string{ | ||
| "-f", | ||
| "-i", "nrext64=0", // This requires kernel v5.19, so disable for now. |
There was a problem hiding this comment.
The comment says nrext64=0 requires kernel v5.19 so it's disabled — but the flag is being explicitly set to 0, which disables the feature. The comment is correct but slightly confusing. Consider rewording to: nrext64=0: disable large extent counters for compatibility with kernels < v5.19.
| DEPS=( | ||
| /etc/netconfig | ||
| /etc/mke2fs.conf /sbin/{fsck,mkfs,mount,umount}.{ext{2,3,4},xfs,nfs} | ||
| /etc/mke2fs.conf /usr/sbin/{fsck,mkfs,mount,umount}.{ext{2,3,4},xfs,nfs} |
There was a problem hiding this comment.
Good catch updating paths from /sbin/ to /usr/sbin/ for Debian 13 (which no longer uses the /sbin symlink split). Verify that /usr/sbin/mount.nfs and /usr/sbin/umount.nfs actually exist in trixie — historically NFS mount helpers may be in different locations depending on the nfs-common package version.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Now all binaries are under /usr, we can remove the logic to search both.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/hold
For upstream distroless image is still preview.Released now