add support for matchConditions in the helm chart#4828
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BojanZelic-DD The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @BojanZelic-DD! |
|
Hi @BojanZelic-DD. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
#4811
Description
Adds support for matchConditions so that the webhook only gets fired for
Serviceobjects that it actually cares about (user configurable but a good default isobject.spec.type == 'LoadBalancer')Currently if the webhook is down, users cannot create
Servicek8s objects, this allows them to be created.It's more of an issue for us during the cluster bootstrap process and removes some cyclical dependencies.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯