Skip to content

feat: make leader election lease duration configurable#4842

Open
Dasmat13 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Dasmat13:feature/configurable-lease-duration
Open

feat: make leader election lease duration configurable#4842
Dasmat13 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Dasmat13:feature/configurable-lease-duration

Conversation

@Dasmat13

Copy link
Copy Markdown

Closes #3823.

This PR implements a configurable leaseDurationSeconds for the AWS Load Balancer Controller by introducing an opt-in command-line flag (--leader-election-lease-duration) and updating the Helm chart values/templates/README.

Changes:

  • Added --leader-election-lease-duration flag to the controller manager.
  • Designed the flag to be strictly opt-in (omitting it retains controller-runtime's built-in defaults, as requested by maintainers).
  • Added leaderElectionLeaseDuration to the Helm values and templates, and documented it in the README.
  • Added unit tests in pkg/config/runtime_config_test.go to test the options building logic.

Signed-off-by: Dasmat13 <gptdasmat@gmail.com>
@kubernetes-prow
kubernetes-prow Bot requested a review from oliviassss July 16, 2026 18:29
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dasmat13
Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested a review from wweiwei-li July 16, 2026 18:29
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @Dasmat13!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @Dasmat13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2026
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2026
@Dasmat13
Dasmat13 force-pushed the feature/configurable-lease-duration branch from b6c77e2 to 91b1097 Compare July 18, 2026 10:40
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2026
@Dasmat13

Copy link
Copy Markdown
Author

Hi @oliviassss and @wweiwei-li 👋

When you have a chance, could you please take a look at this PR? It also needs /ok-to-test before the required CI jobs can run.

The implementation keeps the feature opt-in, so existing behavior remains unchanged unless --leader-election-lease-duration is explicitly configured. Happy to make any changes based on your feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make leaseDurationSeconds of a lease owned by AWS Load Balancer Controller configurable

1 participant