feat: make leader election lease duration configurable#4842
Conversation
Signed-off-by: Dasmat13 <gptdasmat@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Dasmat13 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Dasmat13! |
|
Hi @Dasmat13. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b6c77e2 to
91b1097
Compare
|
Hi @oliviassss and @wweiwei-li 👋 When you have a chance, could you please take a look at this PR? It also needs The implementation keeps the feature opt-in, so existing behavior remains unchanged unless |
Closes #3823.
This PR implements a configurable
leaseDurationSecondsfor the AWS Load Balancer Controller by introducing an opt-in command-line flag (--leader-election-lease-duration) and updating the Helm chart values/templates/README.Changes:
--leader-election-lease-durationflag to the controller manager.controller-runtime's built-in defaults, as requested by maintainers).leaderElectionLeaseDurationto the Helm values and templates, and documented it in the README.pkg/config/runtime_config_test.goto test the options building logic.