[release-1.35] cleanup: add folderName validation to reject invalid characters#3078
Merged
k8s-ci-robot merged 4 commits intokubernetes-sigs:release-1.35from Apr 12, 2026
Conversation
Validate folderName parameter in both CreateVolume and NodeStageVolume to reject characters not allowed in Azure file share folder names: - Invalid characters: \ : * ? " < > | - Control characters (0x00-0x1F) - Directory traversal (..) - Segments ending with period or space - Empty path segments Empty folderName is allowed. Folder name supports '/' as path separator for nested folders.
- Use %q for folderName in error messages for clarity with whitespace/dots - Also reject '.' as path segment (not just '..') - Fix misleading test name 'valid single dot segment' -> 'invalid single dot segment' - Add NodeStageVolume test for invalid folderName - Add CreateVolume test for invalid folderName in storage class
Null bytes in folder names can truncate C strings at the OS layer, leading to path injection risks. Add an early check before segment parsing to explicitly reject null bytes with a clear error message.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3071
/assign andyzhangx