🐛 helm: preserve whitespace in metrics template values#1039
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @spnngl! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @spnngl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Hi, This needs a rebase on top of main HEAD to fix govuln CI failure |
|
We are planning to cut a new operator release and include this fix in the release. |
The metrics field templates used {{- which strips leading whitespace,
causing invalid YAML output like 'diagnosticsAddress:localhost:8443'
instead of 'diagnosticsAddress: localhost:8443'.
This resulted in admission webhook rejections with error:
'cannot unmarshal string into Go struct field ManagerSpec.spec.manager.metrics
of type v1alpha2.ControllerMetrics'
Remove the dash from {{- to {{ for insecureDiagnostics and
diagnosticsAddress fields across all provider templates.
7fdc931 to
fb78d48
Compare
kubernetes-prow
Bot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: dd3205bb622b70e1675fbafedd73bf49f92ff16f |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
5 participants
What this PR does / why we need it:
The metrics field templates used {{- which strips leading whitespace, causing invalid YAML output like 'diagnosticsAddress:localhost:8443' instead of 'diagnosticsAddress: localhost:8443'.
This resulted in admission webhook rejections with error: 'cannot unmarshal string into Go struct field ManagerSpec.spec.manager.metrics of type v1alpha2.ControllerMetrics'
Remove the dash from {{- to {{ for insecureDiagnostics and diagnosticsAddress fields across all provider templates.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1038