Skip to content

🌱 Switch from docker to moby dependencies#13545

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:switch-from-docker-to-moby
Apr 8, 2026
Merged

🌱 Switch from docker to moby dependencies#13545
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
fabriziopandini:switch-from-docker-to-moby

Conversation

@fabriziopandini
Copy link
Copy Markdown
Member

@fabriziopandini fabriziopandini commented Apr 7, 2026

What this PR does / why we need it:
Weekly scan is failing due to vulnerabilities in github.com/docker/docker.
It turns out that we cannot bump to recent version of this package due to breaking changes in v29 release, so moving to the new set of imports as recommended in moby/moby#52266

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@fabriziopandini fabriziopandini added the area/dependency Issues or PRs related to dependency changes label Apr 7, 2026
@k8s-ci-robot k8s-ci-robot requested review from elmiko and enxebre April 7, 2026 14:10
@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 7, 2026

/test?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2026
@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 7, 2026

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

@fabriziopandini fabriziopandini force-pushed the switch-from-docker-to-moby branch 2 times, most recently from 9067864 to 313faa3 Compare April 7, 2026 14:28
@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 7, 2026

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

@cprivitere
Copy link
Copy Markdown
Member

cprivitere commented Apr 7, 2026

Actual documentation for the change is here: https://github.com/moby/moby/releases/tag/docker-v29.0.0

@fabriziopandini fabriziopandini force-pushed the switch-from-docker-to-moby branch from 313faa3 to 49528b0 Compare April 7, 2026 17:25
@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 7, 2026

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

This was referenced Apr 7, 2026
Merged
Merged
@sivchari
Copy link
Copy Markdown
Member

sivchari commented Apr 8, 2026

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

LGTM label has been added.

DetailsGit tree hash: 67b61450c04b5ddb1e09263b9aab3c57ea5b7640

Karthik-K-N
Karthik-K-N reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
/lgtm

@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 8, 2026

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

@fabriziopandini
Copy link
Copy Markdown
Member Author

fabriziopandini commented Apr 8, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
@k8s-ci-robot k8s-ci-robot merged commit 343f400 into kubernetes-sigs:main Apr 8, 2026
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Apr 8, 2026
@fabriziopandini fabriziopandini deleted the switch-from-docker-to-moby branch April 10, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@enxebre enxebre Awaiting requested review from enxebre

1 more reviewer

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Karthik-K-N Karthik-K-N

@sivchari sivchari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

5 participants

@fabriziopandini @cprivitere @sivchari @k8s-ci-robot @Karthik-K-N