chore: add helm chart packaging & pushing to release process#130
chore: add helm chart packaging & pushing to release process#130fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
kind/feature
|
@fmuyassarov: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fmuyassarov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
fmuyassarov
force-pushed
the
chore/helm-chart-release
branch
from
fba069b to
88a0a4f
Compare
|
I know that @gauravkghildiyal has handled some of the releases previously. Bundling these two should be fine right? Will let @gauravkghildiyal give the final approval. /lgtm |
k8s-ci-robot
added
the
lgtm
gauravkghildiyal
left a comment
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Thanks @fmuyassarov.
| - REGISTRY=gcr.io/k8s-staging-networking | ||
| - IMAGE_NAME=dranet | ||
| args: ['release'] | ||
| - TAG=$TAG_NAME |
There was a problem hiding this comment.
Non-blocking: I'm a bit uncertain if the TAG will work out correctly (and I also recognize that the current behaviour is also not correct where we don't correctly tag images). Something we'll need to verify separately from this issue whether TAG=$TAG_NAME was sufficient here to fix things.
| - IMAGE_NAME=dranet | ||
| args: ['release'] | ||
| - TAG=$TAG_NAME | ||
| args: ['ensure-helm', 'release'] |
There was a problem hiding this comment.
Why do we have ensure-helm separately rather than making it as a dependency of one of the Make targets (similar to ensure-buildx)?
4 participants
What type of PR is this?
/kind feature
/kind dependency
What this PR does / why we need it:
Add Helm chart publishing steps to the release pipeline so that dranet charts are automatically packaged and pushed to the OCI registry on every tagged release.
Which issue(s) this PR is related to:
Part of #128
Special notes for your reviewer:
Does this PR introduce a user-facing change?