Skip to content

refactor: Replace NamespacedName with EndPointKey for endpoint identification#2705

Open
zetxqx wants to merge 1 commit intokubernetes-sigs:mainfrom
zetxqx:dpaware-prefix
Open

refactor: Replace NamespacedName with EndPointKey for endpoint identification#2705
zetxqx wants to merge 1 commit intokubernetes-sigs:mainfrom
zetxqx:dpaware-prefix

Conversation

@zetxqx
Copy link
Copy Markdown
Contributor

@zetxqx zetxqx commented Mar 27, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR refactors the EPP's internal endpoint identification mechanism by replacing the generic Kubernetes NamespacedName with a specialized plugin.EndPointKey. This new type explicitly
includes the endpoint's port, providing a more precise way to identify backends across the datastore, metrics, and scheduling framework.

The previous NamespacedName is misleading for supporting DataParallel where an inferencePool has multiple targetPorts, please see: #2699 (comment) for an example.

Key Changes:

  • Type Definition: Introduced EndPointKey in pkg/epp/framework/interface/plugin which encapsulates Name, Namespace, and Port.
  • Datalayer: Updated EndpointMetadata to use the new Key field, enabling better tracking of multi-port or non-pod endpoints in the future.
  • Interface Refactoring: Updated Datastore, PodList, and Handle interfaces to consume and return EndPointKey instead of NamespacedName.

Which issue(s) this PR fixes:

Related to: #2699

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 27, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 27, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5e166f4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69cc674f1860030008036b95
😎 Deploy Preview https://deploy-preview-2705--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zetxqx
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from danehans March 27, 2026 21:23
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2026
@k8s-ci-robot k8s-ci-robot requested a review from liu-cong March 27, 2026 21:23
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 27, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Mar 27, 2026

/hold

I would wait a bit, there are a number of pending PRs that will conflict with this

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 27, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@zetxqx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-verify-main 5e166f4 link true /test pull-gateway-api-inference-extension-verify-main
pull-gateway-api-inference-extension-test-e2e-main 5e166f4 link true /test pull-gateway-api-inference-extension-test-e2e-main
pull-gateway-api-inference-extension-test-unit-main 5e166f4 link true /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants