refactor: Replace NamespacedName with EndPointKey for endpoint identification#2705
refactor: Replace NamespacedName with EndPointKey for endpoint identification#2705zetxqx wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zetxqx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold I would wait a bit, there are a number of pending PRs that will conflict with this |
|
@zetxqx: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR refactors the EPP's internal endpoint identification mechanism by replacing the generic Kubernetes NamespacedName with a specialized
plugin.EndPointKey. This new type explicitlyincludes the endpoint's port, providing a more precise way to identify backends across the datastore, metrics, and scheduling framework.
The previous NamespacedName is misleading for supporting DataParallel where an inferencePool has multiple targetPorts, please see: #2699 (comment) for an example.
Key Changes:
Which issue(s) this PR fixes:
Related to: #2699
Does this PR introduce a user-facing change?: