fix: stop reseeding picker RNG on every pick#2805
fix: stop reseeding picker RNG on every pick#2805k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Fixes kubernetes-sigs#2804 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
danehans
force-pushed
the
fix-picker-rng-seeding
branch
from
82fecae to
2636202
Compare
danehans
changed the title
|
Keywords which can automatically close issues and hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
danehans
removed
the
do-not-merge/invalid-commit-message
|
/assign @kaushikmitr |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 participants
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
This switches picker randomness away from creating a fresh time-seeded RNG on every call and instead uses a shared locked RNG stream for shuffle and weighted sampling.
That removes timing-sensitive behavior in the weighted random picker path and stabilizes the picker tests that can fail intermittently in broader test and release runs.
Which issue(s) this PR fixes:
Fixes #2804
Does this PR introduce a user-facing change?: