Skip to content

fix: stage conformance/go.sum in release helper#2806

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
danehans:fix-release-quickstart-go-sum
Apr 7, 2026
Merged

fix: stage conformance/go.sum in release helper#2806
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
danehans:fix-release-quickstart-go-sum

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Apr 7, 2026

What type of PR is this?
/kind bug

What this PR does / why we need it:
This updates the release helper to stage conformance/go.sum alongside conformance/go.mod after the conformance module dependency is updated during make release.

Without this, the release workflow can leave checksum changes unstaged and produce an incomplete release commit.

Which issue(s) this PR fixes:
Fixes #2803

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. labels Apr 7, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 949af22
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69d55f2501d41100084e3f18
😎 Deploy Preview https://deploy-preview-2806--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2026
@k8s-ci-robot k8s-ci-robot requested review from kfswain and liu-cong April 7, 2026 19:44
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2026
Fixes kubernetes-sigs#2803

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans danehans force-pushed the fix-release-quickstart-go-sum branch from 821e59a to 949af22 Compare April 7, 2026 19:46
@danehans danehans changed the title Stage conformance/go.sum in release helper fix: stage conformance/go.sum in release helper Apr 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Keywords which can automatically close issues and hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 949af22 fix: stage conformance/go.sum in release helper
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danehans danehans removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 7, 2026
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 7, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit dc422af into kubernetes-sigs:main Apr 7, 2026
13 checks passed
@danehans danehans deleted the fix-release-quickstart-go-sum branch April 7, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hack/release-quickstart.sh does not stage conformance/go.sum

3 participants