Skip to content

frontend: Fix GRPCRoute section ID and remove debug console.log#5052

Open
NAME-ASHWANIYADAV wants to merge 2 commits intokubernetes-sigs:mainfrom
NAME-ASHWANIYADAV:fix/grpcroute-section-id
Open

frontend: Fix GRPCRoute section ID and remove debug console.log#5052
NAME-ASHWANIYADAV wants to merge 2 commits intokubernetes-sigs:mainfrom
NAME-ASHWANIYADAV:fix/grpcroute-section-id

Conversation

@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Contributor

Fixes #5051

Summary

This PR fixes a copy-paste bug in GRPCRouteDetails where the section ID
was incorrectly set to headlamp.httproute-parentrefs instead of
headlamp.grpcroute-parentrefs. This also removes leftover debug
console.log statements from production code across several files.

Changes

Bug fix:

  • GRPCRouteDetails.tsx: Fix section ID from headlamp.httproute-parentrefs
    to headlamp.grpcroute-parentrefs

Debug log cleanup:

  • clusterRequests.ts: Remove console.log in remove() that logged
    every DELETE request URL and options
  • HTTPRouteDetails.tsx: Remove console.log in RuleBackendRefs
  • NewProjectPopup.tsx: Remove console.log in onChange handler
  • portforward/index.tsx: Change console.log to console.error for
    port forward start errors
  • useSidebarItems.tsx: Change console.log to console.error for
    CRD fetch errors

Steps to Test

  1. Verify GRPCRouteDetails renders correctly with the new section ID
  2. Open browser DevTools console
  3. Confirm no debug console.log output from the modified files
  4. Verify error scenarios still log via console.error in portforward
    and sidebar components

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NAME-ASHWANIYADAV
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 4, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: NAME-ASHWANIYADAV / name: NAME-ASHWANIYADAV (aaadc16, cbfd0e7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @NAME-ASHWANIYADAV!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 4, 2026
@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Contributor Author

/assign @sniok

@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Contributor Author

@sniok Hey! Could you share a rough estimate of when you might be able to review this PR? Thanks 🙂

@NAME-ASHWANIYADAV
Copy link
Copy Markdown
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@NAME-ASHWANIYADAV: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sniok sniok removed their assignment Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GRPCRouteDetails uses incorrect section ID copied from HTTPRouteDetails

3 participants