frontend: pods: fix status icon stuck on warning after pod becomes ready#5059
frontend: pods: fix status icon stuck on warning after pod becomes ready#5059nidhi-9900 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nidhi-9900 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @nidhi-9900! |
sniok
left a comment
There was a problem hiding this comment.
thanks for the PR, the code looks good but could you make sure not to include a merge commit
Summary
The pod status icon in the list view was getting stuck on warning even after the pod was Running and healthy. It only fixed itself after a page refresh. The issue was that getValue was only returning the reason string ("Running"), which stayed the same even when the Ready condition changed : so the table never re-rendered. Added the Ready condition status to the return value so it picks up the change.
Related Issue
Fixes #4905
Changes
getValuein the status column infrontend/src/components/pod/List.tsxto return both the reason and the Ready condition statusSteps to Test
kubectl create deployment nginx-test --image=nginxNotes for the Reviewer
List.tsxis changed