frontend: Replace ts-ignore with proper type fixes#5061
Open
skoeva wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
frontend: Replace ts-ignore with proper type fixes#5061skoeva wants to merge 1 commit intokubernetes-sigs:mainfrom
skoeva wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
skoeva
added
frontend
k8s-ci-robot
added
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashu8912, skoeva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
illume
reviewed
Apr 7, 2026
|
|
||
| // @ts-ignore | ||
| return this._class().apiEndpoint.delete(...args, params, this._clusterName); | ||
| return (this._class().apiEndpoint.delete as (...args: any[]) => Promise<any>)( |
Contributor
There was a problem hiding this comment.
I don't think these should be "any"?
illume
reviewed
Apr 7, 2026
|
|
||
| // @ts-ignore | ||
| return this._class().apiEndpoint.patch(...args, {}, this._clusterName); | ||
| return (this._class().apiEndpoint.patch as (...args: any[]) => Promise<any>)( |
Contributor
There was a problem hiding this comment.
Also, the any here I think is wrong.
(It is a bit better than using ts-ignore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes replace
@ts-ignoresuppressions with proper fixes across three files:KubeObject.ts- targeted function casts ondeleteandpatchspread callshooks.ts-Object.assigntuple pattern to satisfy the intersection return typegraphLayout.tsx- added missinglabel?field toElkEdgeWithoutData