frontend: ClusterSettings page refactor#5063
Open
sniok wants to merge 2 commits intokubernetes-sigs:mainfrom
Open
frontend: ClusterSettings page refactor#5063sniok wants to merge 2 commits intokubernetes-sigs:mainfrom
sniok wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Extract shared cluster settings load/store logic into a dedicated hook that keeps React state and localStorage in sync. This provides a single source of truth that parent components can share with children via props.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sniok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/XL
Contributor
Contributor
Author
|
whoops, thanks for pointing that out |
SettingsCluster now owns the settings via useClusterSettings and passes them to NodeShellSettings, PodDebugSettings, and ClusterNameEditor as props, removing duplicated load/store logic and debounce timers from each child. Appearance changes (accent color, icon) apply immediately instead of requiring a separate save button. ColorPicker no longer needs an onError callback and both picker dialogs get consistent form field styling. Stories supply settings through props instead of pre-seeding localStorage, and snapshots are updated accordingly.
sniok
force-pushed
the
cluster-settings-refactor
branch
from
52ffda4 to
3b2d0de
Compare
sniok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5062
Simplify cluster settings by having SettingsCluster own the settings state and pass it down to child components, removing duplicated load/store logic
Steps to Test