backend/plugins: use structured logging in ListPlugins#5072
Open
NAME-ASHWANIYADAV wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
backend/plugins: use structured logging in ListPlugins#5072NAME-ASHWANIYADAV wants to merge 1 commit intokubernetes-sigs:mainfrom
NAME-ASHWANIYADAV wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
Author
|
/assign @sniok |
a6a62c8 to
af1a4d1
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NAME-ASHWANIYADAV The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5069
What this PR does
Refactors ListPlugins to replace raw
fmt.Printf/fmt.Printlncalls with Headlamp's structuredlogger.Log, and removes the brittleos.Pipestdout-capture technique from the test.Changes
fmt.Printf/fmt.Printlncalls withlogger.Log(logger.LevelInfo, ...)using structured key-value maps (plugin,type, directory)captureOutput(os.Pipe hack), addt.Helper()to createPlugin, rewrite TestListPlugins to assert no-error directlyWhy
fmt.Printlnfor output - every other package uses the structured logger.captureOutputtest helper hijackedos.Stdoutviaos.Pipe, which is fragile and not goroutine-safe.Testing
go vet ./pkg/plugins/...- Cleango fmt ./pkg/plugins/...- No changesgo test ./pkg/plugins/... -v- All tests pass