fix(cronjob): handle undefined spec.suspend in List and Details#5085
Open
Athang69 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
fix(cronjob): handle undefined spec.suspend in List and Details#5085Athang69 wants to merge 1 commit intokubernetes-sigs:mainfrom
Athang69 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Athang69 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash in the CronJob list and details pages when
spec.suspendis not explicitly set in the CronJob manifest. Kubernetes defaultsspec.suspendtofalsebut does not always include it in the API response, causing.toString()to be called onundefinedand throwing aTypeErrorRelated Issue
Fixes #5083
Changes
frontend/src/components/cronjob/List.tsxadded?? falsefallback before.toString()onspec.suspendin the Suspend columngetValuefrontend/src/components/cronjob/Details.tsxadded?.optional chaining onspecand?? falsefallback forisCronSuspendedderivationfrontend/src/components/cronjob/Details.tsxadded?? falsefallback before.toString()onspec.suspendin theextraInfoSuspend fieldSteps to Test
spec.suspende.g. a Helm generated CronJobfalsein the Suspend column without crashingfalsefor the Suspend fieldspec.suspend:trueexplicitly set and verify it still showstruecorrectlyNotes for the Reviewer
spec.suspendis defined as optional in the Kubernetesbatch/v1 CronJobSpecits absence from the API response is valid behaviour, not a bug in the clusterThe
?? falsefallback exactly matches the Kubernetes-defined default for this field, so there is no behaviour change for CronJobs that have the field explicitly setThe additional
?.onspecinisCronSuspendedguards against the loading phase before the API response arrives, which the originalcronJob?.spec.suspenddid not cover