Skip to content

docs: RFC to Allow blocking NodePool disruption and consolidation via external health signals#2901

Open
vaietc wants to merge 3 commits intokubernetes-sigs:mainfrom
pinterest:rfcs/circuit-breaker
Open

docs: RFC to Allow blocking NodePool disruption and consolidation via external health signals#2901
vaietc wants to merge 3 commits intokubernetes-sigs:mainfrom
pinterest:rfcs/circuit-breaker

Conversation

@vaietc
Copy link
Copy Markdown

@vaietc vaietc commented Mar 10, 2026

Fixes #2497

Description

This adds a few proposed paths to control disruption and consolidation actions via external health signals. Currently, this change only includes an initial RFC and does not dive into implementation details yet. As the feedback progresses, I will add more information on specific changes within the code base.

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 10, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot requested review from jmdeal and tallaxes March 10, 2026 05:16
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vaietc
Once this PR has been reviewed and has the lgtm label, please assign njtran for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @vaietc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2026
@vaietc vaietc changed the title Initial version of circuit breaking design for Karpenter docs: RFC to Allow blocking NodePool disruption and consolidation via external health signals Mar 10, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 11, 2026
@DerekFrank
Copy link
Copy Markdown
Collaborator

Summarizing notes from working group:

  • Would this be simpler as a nodepool level do-not-disrupt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow circuit breaking controls to stall Drift and Consolidation actions

3 participants