feat: Support spotToSpotConsolidation per nodepool#2908
feat: Support spotToSpotConsolidation per nodepool#2908Fs02 wants to merge 3 commits intokubernetes-sigs:mainfrom
Conversation
|
Welcome @Fs02! |
|
Hi @Fs02. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fs02 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@DerekFrank @tallaxes please take a look 🙏 |
Fixes #1449
Description
spotToSpotConsolidationfield to NodePool's Disruption spec, allowing per-NodePool control over spot-to-spot consolidationSpotToSpotConsolidationfeature gate for that NodePoolWhen unset, falls back to the global feature gate behavior
How was this change tested?
Use kind and kwook to create nodepools, one with spotToSpotConsolidation enabled and the other one disabled.
Run a simple test by scaling out and scaling in test pods and checking the Unconsolidatable events.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.