POC: speedup single node consolidation by grouping nodes and pools to a single node-type#2910
POC: speedup single node consolidation by grouping nodes and pools to a single node-type#2910grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grosser The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @grosser. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b4345d4 to
e792701
Compare
e792701 to
b388f4c
Compare
Description
this took us from ~5m -> 30s because we have lots of nodes and node-pools
the label for grouping should be made user-configurable, see #2871 and #2814
we sadly had to also add a delay after each consolidation since otherwise our node-churn almost doubled
that would be another useful feature to have as a config option
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.