Skip to content

POC: speedup single node consolidation by grouping nodes and pools to a single node-type#2910

Draft
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/fast-single
Draft

POC: speedup single node consolidation by grouping nodes and pools to a single node-type#2910
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/fast-single

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Mar 12, 2026

Description
this took us from ~5m -> 30s because we have lots of nodes and node-pools
the label for grouping should be made user-configurable, see #2871 and #2814

we sadly had to also add a delay after each consolidation since otherwise our node-churn almost doubled
that would be another useful feature to have as a config option

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grosser
Once this PR has been reviewed and has the lgtm label, please assign derekfrank for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @grosser. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2026
@grosser grosser force-pushed the grosser/fast-single branch 2 times, most recently from b4345d4 to e792701 Compare March 23, 2026 23:08
@grosser grosser force-pushed the grosser/fast-single branch from e792701 to b388f4c Compare March 27, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants