feat: Do nit emit DisruptionBlocked events for do-not-disrupt annotation blocking since this is an intentional user action#2928
Conversation
…ocking since this is an intentional user action
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: grosser The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @grosser. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description

karpenter spams our logs/events/api with these DisruptionBlocked events since our
karpenter.sh/do-not-disruptnodes are evaluated on each disruption cycle, the messages/events/api-calls are just noise thoughTesting for the string is not very elegant, so open for ideas there, or if this makes sense to be an option (env var ?)
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.