Skip to content

feat: Do nit emit DisruptionBlocked events for do-not-disrupt annotation blocking since this is an intentional user action#2928

Open
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/silence
Open

feat: Do nit emit DisruptionBlocked events for do-not-disrupt annotation blocking since this is an intentional user action#2928
grosser wants to merge 2 commits intokubernetes-sigs:mainfrom
zendesk:grosser/silence

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Mar 21, 2026

Description
karpenter spams our logs/events/api with these DisruptionBlocked events since our karpenter.sh/do-not-disrupt nodes are evaluated on each disruption cycle, the messages/events/api-calls are just noise though
image

Testing for the string is not very elegant, so open for ideas there, or if this makes sense to be an option (env var ?)

How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grosser
Once this PR has been reviewed and has the lgtm label, please assign ellistarn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from tallaxes and tzneal March 21, 2026 18:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @grosser. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants