Skip to content

fix: use accumulator in lo.Reduce for disruption pod count#2931

Open
nicknikolakakis wants to merge 1 commit intokubernetes-sigs:mainfrom
nicknikolakakis:fix/2888-lo-reduce-accumulator
Open

fix: use accumulator in lo.Reduce for disruption pod count#2931
nicknikolakakis wants to merge 1 commit intokubernetes-sigs:mainfrom
nicknikolakakis:fix/2888-lo-reduce-accumulator

Conversation

@nicknikolakakis
Copy link
Copy Markdown

Summary

The lo.Reduce callback in Command.LogValues() discards the accumulator (_ int), so the pod-count field in disruption logs only reports the last candidate's pod count instead of the sum across all candidates.

Before: func(_ int, cd *Candidate, _ int) int { return len(cd.reschedulablePods) }
After: func(acc int, cd *Candidate, _ int) int { return acc + len(cd.reschedulablePods) }

Single-candidate disruptions were unaffected (last == only), but multi-node consolidation under-reported.

Fixes #2888

Test plan

  • go build ./pkg/controllers/disruption/... — builds clean
  • Existing disruption tests (CI)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nicknikolakakis
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @nicknikolakakis!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @nicknikolakakis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2026
The lo.Reduce callback discarded the accumulator, so podCount in
Command.LogValues() only reported the last candidate's pod count
instead of the sum across all candidates.
@nicknikolakakis nicknikolakakis force-pushed the fix/2888-lo-reduce-accumulator branch from 48fc250 to 09d39c2 Compare March 25, 2026 11:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lo.Reduce in Command.LogValues discards accumulator, reports last candidate's pod count instead of total

2 participants